chore: use pod install instead of pod-install (#520)

<!-- Please provide enough information so that others can review your
pull request. -->
<!-- Keep pull requests small and focused on a single change. -->

### Summary

<!-- What existing problem does the pull request solve? Can you solve
the issue with a different approach? -->

Pod-install is not adding appropriate node version cause build to break
in ci.

`yarn pod-install` adds `.xcode.env.local` as 
`export
NODE_BINARY=/private/var/folders/pw/n0k7yhwx5lx99s1bswyxq1tc0000gp/T/xfs-713c155c/node`

Whereas `pod install` seems to be working fine.





### Test plan

<!-- List the steps with which we can test this change. Provide
screenshots if this changes anything visual. -->

---------

Co-authored-by: Satyajit Sahoo <[email protected]>

.github/workflows/build-templates.yml

@@ -250,7 +250,8 @@ jobs:
         if: env.ios_build == 1 && env.turbo_cache_hit_ios != 1 && steps.library-cocoapods-cache.outputs.cache-hit != 'true'
         working-directory: ${{ env.work_dir }}
         run: |
-          yarn pod-install example/ios
+          cd example/ios
+          pod install
         env:
           NO_FLIPPER: 1
 

packages/create-react-native-library/src/utils/generateExampleApp.ts

@@ -47,10 +47,6 @@ const PACKAGES_TO_ADD_WEB_DEV = {
   'babel-loader': '^8.1.0',
 };
 
-const PACKAGES_TO_ADD_NATIVE_DEV = {
-  'pod-install': '^0.1.0',
-};
-
 export default async function generateExampleApp({
   type,
   dest,
@@ -164,8 +160,6 @@ export default async function generateExampleApp({
     });
 
     scripts.web = 'expo start --web';
-  } else {
-    Object.assign(devDependencies, PACKAGES_TO_ADD_NATIVE_DEV);
   }
 
   await fs.writeJSON(path.join(directory, 'package.json'), pkg, {

packages/create-react-native-library/templates/common/$.github/workflows/ci.yml

@@ -145,7 +145,8 @@ jobs:
       - name: Install cocoapods
         if: env.turbo_cache_hit != 1 && steps.cocoapods-cache.outputs.cache-hit != 'true'
         run: |
-          yarn pod-install example/ios
+          cd example/ios
+          pod install
         env:
           NO_FLIPPER: 1
 

packages/create-react-native-library/templates/common/$package.json

@@ -72,9 +72,6 @@
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-prettier": "^4.0.0",
     "jest": "^28.1.1",
-<% if (example === 'native') { -%>
-    "pod-install": "^0.1.0",
-<% } -%>
     "prettier": "^2.0.5",
     "react": "17.0.2",
     "react-native": "0.70.0",

packages/create-react-native-library/templates/common/CONTRIBUTING.md

@@ -61,7 +61,9 @@ By default, the example is configured to build with the old architecture. To run
 2. For iOS, run:
 
    ```sh
-   RCT_NEW_ARCH_ENABLED=1 yarn pod-install example/ios
+   cd example/ios
+   RCT_NEW_ARCH_ENABLED=1 pod install
+   cd -
    yarn example ios
    ```