-
Notifications
You must be signed in to change notification settings - Fork 191
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: use node to call codegen (#685)
### Summary We were using `npx` to call the React Native Community CLI for codegen. However, not every environment has `npx` available. This adds custom logic to invoke the RNCCLI only using the node binary. This also emits a better error message when the user doesn't have `@react-native-community/cli` installed on their library project. ### Test plan 1. Create a new architecture supported library 3. Call `yarn bob build --target codegen` 3. Make sure the command passes without any problems
- Loading branch information
Showing
2 changed files
with
69 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
import { type SpawnOptions } from 'node:child_process'; | ||
import { spawn } from './spawn'; | ||
import path from 'node:path'; | ||
import fs from 'fs-extra'; | ||
import assert from 'node:assert'; | ||
|
||
// This is a special case for calling bob from the XCode scripts | ||
// XCode scripts don't have the node binary properly set | ||
// We expose an env value for node instead. | ||
const NODE_BINARY = process.env['NODE_BINARY'] || 'node'; | ||
|
||
/** | ||
* Runs the React Native Community CLI with the specified arguments | ||
*/ | ||
export async function runRNCCli( | ||
args: string[], | ||
options: SpawnOptions = { | ||
stdio: 'ignore', | ||
} | ||
) { | ||
const rncCliBinaryName = await getCliBinaryName(); | ||
|
||
const RNC_CLI_BINARY_PATH = path.resolve( | ||
process.cwd(), // We are always expected to run in the library | ||
'node_modules', | ||
'.bin', | ||
rncCliBinaryName | ||
); | ||
|
||
return await spawn(NODE_BINARY, [RNC_CLI_BINARY_PATH, ...args], options); | ||
} | ||
|
||
async function getCliBinaryName(): Promise<string> { | ||
const rncCliPackagePath = await spawn(NODE_BINARY, [ | ||
'-e', | ||
`console.log(require.resolve('@react-native-community/cli/package.json'))`, | ||
]); | ||
|
||
const rncCliPackage = await fs.readJson(rncCliPackagePath); | ||
const binProperty = rncCliPackage.bin as Record<string, string>; | ||
assert( | ||
typeof binProperty === 'object', | ||
"React Native CLI doesn't specify proper binaries" | ||
); | ||
|
||
const binaries = Object.keys(binProperty); | ||
const rncCliBinaryName = binaries[0] as string; | ||
assert( | ||
typeof rncCliBinaryName === 'string', | ||
"React Native Community CLI doesn't have any binaries to run" | ||
); | ||
|
||
return rncCliBinaryName; | ||
} |