Skip to content

Commit

Permalink
fix: devDependencies doesn't exist in rootPackageJson (#584)
Browse files Browse the repository at this point in the history
i faced the following issue:

Cannot set properties of undefined (setting 'react')
/Users/imokhles/.nvm/versions/node/v20.13.1/lib/node_modules/create-react-native-library/lib/index.js:558
rootPackageJson.devDependencies.react =
examplePackageJson.dependencies.react;
                                          ^

TypeError: Cannot set properties of undefined (setting 'react')
at Object.create [as handler]
(/Users/imokhles/.nvm/versions/node/v20.13.1/lib/node_modules/create-react-native-library/lib/index.js:558:43)
  • Loading branch information
iMokhles authored Jul 4, 2024
1 parent a204f38 commit 5a089f1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/create-react-native-library/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,10 @@ async function create(_argv: yargs.Arguments<any>) {
path.join(folder, 'package.json')
);

if (!rootPackageJson.devDependencies) {
rootPackageJson.devDependencies = {};
}

rootPackageJson.devDependencies.react =
examplePackageJson.dependencies.react;
rootPackageJson.devDependencies['react-native'] =
Expand Down

0 comments on commit 5a089f1

Please sign in to comment.