-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(legacy view template): extract view to a separate file #375
Closed
+49
−47
Closed
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
62d04c6
feat(legacy view template): extract view to a separate file
atlj 2ef0685
Merge branch 'main' into @atlj/unify-view-templates
atlj 485c23a
refactor: dont export as default and rename to view
atlj a3d8ea0
feat: extract Native legacy module as well
atlj 8656a9b
fix: export -> export const
atlj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 2 additions & 26 deletions
28
packages/create-react-native-library/templates/native-view-legacy/src/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,2 @@ | ||
import { | ||
requireNativeComponent, | ||
UIManager, | ||
Platform, | ||
ViewStyle, | ||
} from 'react-native'; | ||
|
||
const LINKING_ERROR = | ||
`The package '<%- project.slug -%>' doesn't seem to be linked. Make sure: \n\n` + | ||
Platform.select({ ios: "- You have run 'pod install'\n", default: '' }) + | ||
'- You rebuilt the app after installing the package\n' + | ||
'- You are not using Expo Go\n'; | ||
|
||
type <%- project.name -%>Props = { | ||
color: string; | ||
style: ViewStyle; | ||
}; | ||
|
||
const ComponentName = '<%- project.name -%>View'; | ||
|
||
export const <%- project.name -%>View = | ||
UIManager.getViewManagerConfig(ComponentName) != null | ||
? requireNativeComponent<<%- project.name -%>Props>(ComponentName) | ||
: () => { | ||
throw new Error(LINKING_ERROR); | ||
}; | ||
export { default as <%- project.name -%>View } from './<%- project.name -%>ViewNativeComponent'; | ||
export * from './<%- project.name -%>ViewNativeComponent'; |
25 changes: 25 additions & 0 deletions
25
...native-library/templates/native-view-legacy/src/{%- project.name %}ViewNativeComponent.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,25 @@ | ||||||
import { | ||||||
requireNativeComponent, | ||||||
UIManager, | ||||||
Platform, | ||||||
ViewStyle, | ||||||
} from 'react-native'; | ||||||
|
||||||
const LINKING_ERROR = | ||||||
`The package '<%- project.slug -%>' doesn't seem to be linked. Make sure: \n\n` + | ||||||
Platform.select({ ios: "- You have run 'pod install'\n", default: '' }) + | ||||||
'- You rebuilt the app after installing the package\n' + | ||||||
'- You are not using Expo Go\n'; | ||||||
|
||||||
type <%- project.name -%>Props = { | ||||||
color: string; | ||||||
style: ViewStyle; | ||||||
}; | ||||||
|
||||||
const ComponentName = '<%- project.name -%>View'; | ||||||
|
||||||
export default UIManager.getViewManagerConfig(ComponentName) != null | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Generally good to avoid default exports
Suggested change
|
||||||
? requireNativeComponent<<%- project.name -%>Props>(ComponentName) | ||||||
: () => { | ||||||
throw new Error(LINKING_ERROR); | ||||||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's name this file as
<%- project.name -%>View.tsx
to match the name of the component it exports