Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump the engine node version to 18 #459

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented Sep 13, 2023

Summary

Node 16 LTS has reached EOL. And some libraries are dropping the support for it already. In order to support the transition to Node 18 and make sure everything works properly, we can change all the minimum engine versions to 18.

Test plan

This needs to be tested with a pure Javascript library which uses Expo, and a library with native code which uses the CLI.

  1. Create a new library using npx create-react-native-library some-cool-name.
  2. Complete creating the library and install the dependencies
  3. Build the example app and make sure your library works properly.
  4. Run yarn prepack to make sure your library is building properly.

@atlj atlj force-pushed the @atlj/engines-node-18 branch from 4aad474 to e57f87d Compare September 13, 2023 09:50
@satya164 satya164 merged commit 1a7f290 into main Sep 14, 2023
31 of 32 checks passed
@satya164 satya164 deleted the @atlj/engines-node-18 branch September 14, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants