Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bob)!: remove AAR target support #463

Merged
merged 3 commits into from
Sep 15, 2023
Merged

chore(bob)!: remove AAR target support #463

merged 3 commits into from
Sep 15, 2023

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented Sep 15, 2023 •
edited
Loading

Summary

This removes the (non-working) support for aar targets.
Originally, the aar support was added with #4 to support AndroidX. However, it's not needed anymore so we are removing the support.

Test plan

  1. Create a new library with npx create-react-native-library
  2. Add aar to targets
  3. run yarn prepack
  4. Make sure an error is printed and the program stops.

@atlj atlj mentioned this pull request Sep 15, 2023
Closed
@satya164 satya164 enabled auto-merge (squash) September 15, 2023 12:12
@satya164 satya164 disabled auto-merge September 15, 2023 12:12
@satya164 satya164 merged commit 7bd99b9 into main Sep 15, 2023
32 checks passed
@satya164 satya164 deleted the @atlj/remove-aar branch September 15, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya164 satya164 satya164 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atlj @satya164