Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use project identifier instead of generic #501

Merged
merged 1 commit into from
Dec 6, 2023
Merged

chore: use project identifier instead of generic #501

merged 1 commit into from
Dec 6, 2023

Conversation

dcangulo
Copy link
Contributor

@dcangulo dcangulo commented Dec 3, 2023

Summary

Doesn't really fix/improve anything, just a nitpick. cpp seems too generic. Just close if it's not a welcome change. Thanks!

Test plan

yarn example android

satya164
satya164 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@satya164 satya164 merged commit 8fda2fd into callstack:main Dec 6, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya164 satya164 satya164 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcangulo @satya164