Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove npm publish warning #502

Merged
merged 2 commits into from
Dec 6, 2023
Merged

chore: remove npm publish warning #502

merged 2 commits into from
Dec 6, 2023

Conversation

dcangulo
Copy link
Contributor

@dcangulo dcangulo commented Dec 4, 2023

Summary

Running npm publish shows a warning.

Screenshot 2023-12-05 at 02 19 55

It suggested running npm pkg fix which automatically makes the following changes.

Screenshot 2023-12-05 at 02 21 17

I assumed git is the default since most of the workflows are GitHub-specific.

Also, a nit where a remove an extra line break.

Test plan

N/A

satya164
satya164 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@satya164 satya164 merged commit 6780418 into callstack:main Dec 6, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya164 satya164 satya164 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcangulo @satya164