Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crnl): store metadata with new projects #551

Merged
merged 16 commits into from
Jul 3, 2024

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented Apr 26, 2024

Summary

We need a way to track the project information since we are going to introduce a library upgrade helper. With this PR, when you create a new library using create-react-native-library, it will automatically save;

  1. Version of create-react-native-library used to create the project
  2. The library type (native module, native view, etc.)
  3. The languages used (Kotlin, objective-c, etc.)

into create-react-native-library.json file at the root.

Test plan

  1. Build and run create-react-native-library
  2. Note down the options you have picked
  3. Make sure the create-react-native-library.json file has been generated at the root of your library
  4. Check the version, library type, and languages fields and make sure they are using correct data.

@atlj atlj requested a review from satya164 April 26, 2024 09:50
tsconfig.json Outdated Show resolved Hide resolved
packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved
packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved
packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved
packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved
packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved
packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved
packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved
packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved
@atlj atlj force-pushed the @atlj/store-project-metadata branch from 988961c to d58bced Compare June 10, 2024 13:26
@atlj atlj requested a review from satya164 June 10, 2024 13:57
@atlj atlj force-pushed the @atlj/store-project-metadata branch from 6aff2c6 to b049969 Compare June 11, 2024 11:23
Copy link
Contributor

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly! :shipit:

  "create-react-native-library": {
    "type": "module-mixed",
    "languages": "cpp",
    "version": "0.36.0"
  }

@satya164 satya164 enabled auto-merge July 3, 2024 12:21
@satya164 satya164 added this pull request to the merge queue Jul 3, 2024
@satya164 satya164 removed this pull request from the merge queue due to a manual request Jul 3, 2024
@satya164 satya164 added this pull request to the merge queue Jul 3, 2024
@satya164 satya164 removed this pull request from the merge queue due to a manual request Jul 3, 2024
@satya164 satya164 merged commit cb8f969 into main Jul 3, 2024
32 checks passed
@satya164 satya164 deleted the @atlj/store-project-metadata branch July 3, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants