Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crnl): pass --template blank to create-expo-app #558

Merged
merged 1 commit into from
May 27, 2024

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented May 24, 2024

Summary

With Expo SDK 51, Expo has changed their default app template. This PR passes the --template blank param to create-expo-app so we can use a bare template. This also fixes some of the CI issues we've been having

Test plan

  1. Create a new library and select Javascript as the library language
  2. Make sure the generated library's example/package.json doesn't include expo-router as a dependency (expo-router is a dependency that comes with the new default app template).
  3. Run yarn lint and make sure it passes.

@satya164 satya164 merged commit 87f32b8 into main May 27, 2024
23 of 32 checks passed
@satya164 satya164 deleted the @atlj/create-expo-with-bare-template branch May 27, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants