Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable jetifier for generated native examples #563

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented Jun 11, 2024

Summary

This disables Jetifier for the example apps that are generated for native libraries.
This should also fix the CI issues with Java Heap Space errors. example.

Test plan

  1. cd packages/create-react-native-library
  2. yarn prepare
  3. bin/create-react-native-library
  4. Provide email, repo URL etc.
  5. Pick any native module type for your lib
  6. Pick any language
  7. Once the lib is generated go to example/android/gradle.properties and make sure android.enableJetifier is false.

@atlj atlj requested a review from satya164 June 11, 2024 10:58
@atlj atlj changed the title chore: disable jetifier for generated native examples feat: disable jetifier for generated native examples Jun 11, 2024
@satya164 satya164 changed the title feat: disable jetifier for generated native examples fix: disable jetifier for generated native examples Jun 11, 2024
@atlj atlj merged commit 3676c71 into main Jun 11, 2024
32 checks passed
@atlj atlj deleted the @atlj/disable-jetifier branch June 11, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants