fix: fix build:ios/android commands in test-app example
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
changed the title
build:ios/android commandsbuild:ios/android commands in test-app example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #572 we've introduced
test-appas an option forexampleproject, and CRNL contains two scriptsbuild:iosandbuild:androidthat are injected when creating project, RNTA also contains two scripts named in the same way, which are then replaced - in this Pull Request in relevant scenario I added logic which joins two scripts.Test plan
create-react-native-librarytest-appforexample/build:iosandbuild:androidshould contain logic of creating and bundling app as well as building app with relevant options.