feat: add esm build option for typescript #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/tsc-esm
branch
2 times, most recently
from
9648f45 to
67ce2ce
Compare
satya164
force-pushed
the
@satya164/tsc-esm
branch
from
67ce2ce to
012497a
Compare
atlj
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps up the ESM support to add support for TypeScript as well. For TypeScript to work correctly, it's necessary to have 2 builds (for ESM and CommonJS). With this, we generate one build and then copy the folder, then add a
package.jsonwithtypeproperty for the module system.