Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump release-it and release-it conventional changelog versions #677

Merged

Conversation

coolsoftwaretyler
Copy link
Contributor

@coolsoftwaretyler coolsoftwaretyler commented Nov 7, 2024

Summary

Hey folks, Dependabot is flagging a vulnerability in the vm2 package from this exploit: https://gist.github.com/leesh3288/f693061e6523c97274ad5298eb2c74e9

I think React Native Builder Bob carries that forward through packages: release-it -> proxy-agent -> pac-proxy-agent -> pac-resolver -> degenerator -> vm2

From what I can tell, the vulnerability is basically unused code for any consumer of Builder Bob, but the included versions of release-it and @release-it/conventional-changelog are also pretty old. Bumping those versions should clean up some Dependabot noise for people who use this tool, and keep everyone up to date.

Test plan

Hard to actually test since it's a dev dependency that different users will configure differently, but I did some investigation in all the breaking changes and I think they are quite minor.

For release-it, this would jump across a breaking change in v16 which just removes support for Node v14, and a breaking change in v17 which removes support for Node v16. Both of those are EOL

The plugin, @release-it/conventional-changelog would jump a few breaking versions, but those changes also seem minor:

  1. 6.0.0 doesn't seem to do much other than update some of its own dependencies and change internal tooling for its own GH actions
  2. 7.0.0 is just a break to support release-it 16 and its node deprecation
  3. 8.0.0 drops support for Node v16
  4. 9.0.0 only updates dependencies and adds a gitignore.

Overall seems like a pretty smooth upgrade path.

@atlj
Copy link
Collaborator

atlj commented Nov 8, 2024

LGTM thanks for sending this.

@atlj atlj merged commit 6f9ded9 into callstack:main Nov 8, 2024
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants