Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the paths for codegen generated header files on views #680

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented Nov 8, 2024

Summary

Closes #669

We were trying to import the codegen-generated view scaffold code for iOS from the react target. And since we now generate the codegen scaffold code for the user, it's placed under the same pod as the user's code lives. This means we can now get rid of the import path and just import using the header name.

Note: This will cause problems for users who don't ship their codegen-compiled code. Since this is not a path we want to support, there is no compatibility logic. If these users wish to go without shipping their codegen-compiled code, then they need to add those import paths again. The import paths are described in the Official React Native documentation

Test plan

  1. Generate a new view library that supports the new architecture
  2. Install the pods and trigger a build on iOS
  3. Make sure the example app bulids and runs fine.

@atlj atlj force-pushed the @atlj/fix-ios-codegen-build-issues branch from 358f85c to 6e4bebb Compare November 8, 2024 22:46
@atlj atlj merged commit 6069721 into main Nov 15, 2024
29 checks passed
@atlj atlj deleted the @atlj/fix-ios-codegen-build-issues branch November 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New architecture codegen not working and wrong imports
1 participant