fix: skip compiling fabric view as react native freaks out #720
Conversation
| // Let React Native preset handle the commonjs transform | ||
| // Otherwise this causes issues with `@react-native/babel-plugin-codegen` | ||
| supportsStaticESM: true, |
There was a problem hiding this comment.
@jbroma codegen generates export in invalid position after the file is transformed to commonjs, which causes a syntax error when running the code
There was a problem hiding this comment.
the CJS transform comes from @babel/preset-env and codegen runs as a plugin and the order of execution should be plugins -> presets, this shouldnt be a problem 🤔
There was a problem hiding this comment.
the codegen plugin runs as part of the react native preset and presets run in the reverse order iirc, which means codegen plugin will run after preset-env
There was a problem hiding this comment.
the codegen plugin runs as part of the react native preset and presets run in the reverse order iirc, which means codegen plugin will run after preset-env
but we don't use the RN preset here? and codegen plugin shouldn't run twice since we strip the types here
There was a problem hiding this comment.
@jbroma it is used in ...defaultConfig where example app passes the RN preset. codegen only runs as part of the RN preset.
satya164
force-pushed
the
@satya164/codegen-plugin
branch
3 times, most recently
from
fac2fe2 to
a45b237
Compare
satya164
changed the title
satya164
force-pushed
the
@satya164/codegen-plugin
branch
from
a45b237 to
f6ec3f9
Compare
satya164
force-pushed
the
@satya164/codegen-plugin
branch
from
f6ec3f9 to
1f871ad
Compare
)" This reverts commit 2ec645b.
fixes #719