-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: touch to display tooltip #4479
Open
Steven-MKN
wants to merge
5
commits into
callstack:main
Choose a base branch
from
Steven-MKN:feat/touch-to-display-tooltip-#4206
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: touch to display tooltip #4479
Steven-MKN
wants to merge
5
commits into
callstack:main
from
Steven-MKN:feat/touch-to-display-tooltip-#4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steven-MKN
changed the title
Feature: touch to display tooltip #4206
feat: touch to display tooltip #4206
Aug 19, 2024
Hey @Steven-MKN, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Steven-MKN
changed the title
feat: touch to display tooltip #4206
feat: touch to display tooltip
Aug 19, 2024
Why not just using |
It is a nice prop, but seems the repo dying 😢 |
Hey, I explained here #4206 |
Sad. In favour of what? I can't imagine a react native app without this lib tbh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I would like my users to touch the info icon (not long touch), as this would be more intuitive when it's on a TextInput or similar.
an example where I'd prefer a touch instead of a long touch
Related issue
#4206
Test plan
To test this I have created an example tooltip in a TextInput, the tooltip is set to display on touch. Here is an example:
Screen_recording_20240819_155635.webm