Merge pull request hyrise#261 from bastih/feature/add_test_bcv

Add test to prevent insertion of values larger than what can be represented
came · Nov 19, 2013 · a0fcca9 · a0fcca9
2 parents 085fe8a + a9860e3
commit a0fcca9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/lib/storage/BitCompressedVector.h b/src/lib/storage/BitCompressedVector.h
@@ -95,7 +95,9 @@ class BitCompressedVector : public BaseAttributeVector<T> {
 
   void set(size_t column, size_t row, T value) {
     checkAccess(column, row);
-
+#ifdef EXPENSIVE_ASSERTIONS
+    if (value >= (1 << _bits[column])) throw std::out_of_range("trying to insert value larger than can be stored");
+#endif
     auto offset = _blockOffset(row);
     auto colOffset = _offsetForColumn(column);
     auto block = _blockPosition(row) + (offset + colOffset) / _bit_width;