Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a map (statefully) as we process declarations #288

Merged
merged 7 commits into from
Sep 12, 2024

Conversation

dorchard
Copy link
Member

I noticed some problems with building a constant expression map were coming through into CamFort. This seems to fix things now (makes the associated tests pass in CamFort)- the main idea is in genConstExpMap to find all the statements the declare parameters or have a constants, and then evaluate them one at a time, building a map from values to FRepr representations.

@dorchard dorchard requested a review from raehik September 12, 2024 09:33
Copy link
Collaborator

@raehik raehik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for this! I had a feeling I didn't replace the analysis constant evaluation properly.

@dorchard dorchard merged commit 8f819c0 into master Sep 12, 2024
7 checks passed
@dorchard dorchard deleted the improveConstExpr branch September 30, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants