Fixed bug where treeChange update to ERev always uses T=37 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonConcentrations class can now remember temperature setting, so that when concentrations are updated it no longer defaults to 37 deg C.
…ed. Removed "Ions" checkbox, so always uses calculated Erev.
…ng to voltage/current clamp mode
|
In addition to the Erev updates, a few more updates: Removing an ion channel now removes plots associated with that channel (previously would leave behind "zombie" plots that were visible but didn't get updated). Added field to report membrane voltage at current cursor position. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that whereas the initial Erev calculation uses the parameter temperature, subsequent updates always default to 37 deg C. I tweaked the IonConcentrations class so it now remembers temperature settings, and uses that when concentrations are updated and Nernst potential is recalculated.
Also, Ion checkbox is now on by default, so will always use calculated Erev. In future, might remove the checkbox altogether, as we probably want this behavior all the time.