GSGGR-156 Add OIDC authentication flow for the geoshop frontend #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 27, 2024 10:59
lanseg
force-pushed
the
GSGGR-156-frontend-auth
branch
from
bee3e15 to
cde43ae
Compare
pmauduit
changed the title
gberaudo
approved these changes
Oct 4, 2024
| checkOidcToken(token: string): Observable<{ identity: Partial<IIdentity>; callbackUrl: string; }> { | ||
| this._getApiUrl(); | ||
|
|
||
| const url = new URL(`${this.apiUrl}/oidc/token`); |
There was a problem hiding this comment.
Why not directly create a string?
Suggested change
| const url = new URL(`${this.apiUrl}/oidc/token`); | |
| const url = `${this.apiUrl}/oidc/token`; |
lanseg
pushed a commit
that referenced
this pull request
Dec 2, 2024
* Update Dockerfile * retrieve docker-compose file from other branch * wip on docker-compose file * local init script * Example docker-composition * Remove dotenv * Envvar for ADMIN_USERNAME * chore: setup docker compose dev environment * chore: improve fixtures generation to be compatible with initialized DBs * chore: missing import gettext_lazy import * chore(Dockerfile): remove /mnt/geoshop_data directory creation --------- Co-authored-by: Andrea Borghi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds initializes an open-id authentication for the geoshop-frontend, but to make it fully working there should be an update on the geoshop-backend side. Here is the frontend flow:
If no OIDC provider is configured, OIDC authentication is disabled (see screenshots).
