Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix geolocation Search - use swisstopo API #48

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix geolocation Search - use swisstopo API #48

merged 2 commits into from
Nov 13, 2024

Conversation

marionb
Copy link
Member

@marionb marionb commented Nov 13, 2024 •
edited
Loading

Closes #1

TODO:

  • replace NE search API with the swisstopo API
  • handle point BBOX -> needs some testing
  • BBOX is shifted to the south -> TODO in another PR/Task

@marionb marionb self-assigned this Nov 13, 2024
@marionb marionb force-pushed the Fix_Geolocation_Search branch from 5122566 to 15975c7 Compare November 13, 2024 09:28
@marionb marionb force-pushed the Fix_Geolocation_Search branch from 15975c7 to 8f14c55 Compare November 13, 2024 09:36
@marionb marionb requested a review from lanseg November 13, 2024 09:36
@marionb marionb marked this pull request as ready for review November 13, 2024 09:36
@marionb marionb requested a review from julianhafner November 13, 2024 09:37
julianhafner
julianhafner approved these changes Nov 13, 2024
View reviewed changes
Copy link

@julianhafner julianhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marionb marionb merged commit 37eb1e0 into master Nov 13, 2024
1 check passed
@marionb marionb deleted the Fix_Geolocation_Search branch November 13, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianhafner julianhafner julianhafner approved these changes

@lanseg lanseg lanseg approved these changes

Assignees

@marionb marionb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marionb @lanseg @julianhafner