Finalize i18n setup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgravin
approved these changes
Jan 17, 2024
| "skipLibCheck": true, | ||
| "skipDefaultLibCheck": true, | ||
| "baseUrl": ".", | ||
| "strictNullChecks": false, |
There was a problem hiding this comment.
Did you have issue with the previous config ?
There was a problem hiding this comment.
I needed some adaptions here to allow imports from json for the MelEmbeddedLoader, which did still not work after setting "resolveJsonModule": true and "esModuleInterop": true. I finally ended up taking the config from gn-ui. Not sure if "strictNullChecks": false is actually needed.
to allow importing json for embedded translations
that loads and merges translations from gn-ui and MEL project
npm run i18n:extract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR enables the extraction of strings from the templates and allows the datahub to load translated string values from gn-ui and the MEL project at the same time.
Note: The differing translation file names (
fr_MEL.json) were mainly chosen to facilitate the imports, as apparently aliases cannot be used for JSON files.