Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default values for openSUSE / SLES #78

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tampakrap
Copy link

No description provided.

@tampakrap tampakrap force-pushed the suse branch 3 times, most recently from 1c5ba29 to f728f1e Compare October 1, 2016 11:53
Copy link
Member

@saimonn saimonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Can you please rebase on master ? this should fix the travis build 'json_pure' errors.

Also there's a lint error to fix:

 manifests/config.pp - WARNING: ensure set to present on file resource on line 107

'recursion' => 'no',
if $::osfamily == 'Suse' {
file {'/etc/named.d/default-zones':
ensure => present,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 'file', not 'present'

@tampakrap
Copy link
Author

@saimonn sorry for the delay, I fixed the issue and rebased

@raphink
Copy link
Contributor

raphink commented Jan 11, 2017

Could you add SuSE to metadata.json and make sure it passes tests?

@tampakrap tampakrap force-pushed the suse branch 2 times, most recently from 7f6464c to 1503be7 Compare January 12, 2017 11:16
@tampakrap
Copy link
Author

@raphink added, review please

- create files/suse_default-zones, as the default zones are inside in
  /etc/named.conf in suse distros
- do not create /var/log/bind on suse
- do not create default_logging in suse
  - move the default_logging inside the distro defaults in params.pp
  - add empty default_logging hash in suse
  - do not create logging block in named.conf.options template if @logging is
    empty
Copy link
Contributor

@raphink raphink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some fails still fail on SuSE. Can you fix them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants