Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for camunda pods namespace #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jastonitas
Copy link

Adding support for camunda pods namespace configuration from values.yaml file

Adding support for camunda pods namespace configuration from values.yaml file
@CLAassistant
Copy link

CLAassistant commented Mar 3, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jean Paul Astonitas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jastonitas
Copy link
Author

I already signed the CLA but seems like the workflow check is not taking it :)

Copy link
Collaborator

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @jastonitas
There are a couple of things here.

  1. Please add the namespace to all namespaced resources (not just deployment).
  2. Set the value under .Values.general.namespace and default it to .Release.Namespace, so it will be like this:
namespace: {{ .Values.general.namespace | default .Release.Namespace }}
  1. Add the value to the main values.yaml file:
general:
[...]
  namespace: ""
  1. To test the changes, add custom value to the file ci/custom-values.yaml:
  general:
[...]
  namespace: camunda

@aabouzaid aabouzaid force-pushed the main branch 2 times, most recently from a3be667 to 67e3c3a Compare July 11, 2022 23:28
@thecampagnards thecampagnards force-pushed the main branch 6 times, most recently from 3894d2a to ca7f748 Compare June 7, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants