Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(.ci/config): Add JDK 21 Build Support #4056

Merged
merged 8 commits into from
Feb 16, 2024
Merged

chore(.ci/config): Add JDK 21 Build Support #4056

merged 8 commits into from
Feb 16, 2024

Conversation

psavidis
Copy link
Contributor

Related-to: #4002

@psavidis psavidis added the ci:no-build Prevents any CI stage from running. label Jan 24, 2024
@psavidis psavidis self-assigned this Jan 24, 2024
@psavidis psavidis added ci:jdk Runs the builds for all supported Java versions. and removed ci:no-build Prevents any CI stage from running. labels Jan 24, 2024
This was referenced Jan 24, 2024
Closed
Closed
@psavidis psavidis changed the title chore(.ci/config): Add Java 21 Stages to Jenkins Files chore(.ci/config): Add JDK 21 Build Support Jan 24, 2024
@psavidis psavidis force-pushed the 4002-add-java21-jenkins-support branch from 1a3640e to acc4500 Compare January 29, 2024 08:26
@yanavasileva yanavasileva added the ci:e2e Runs the frontend end-to-end tests. label Feb 2, 2024
@psavidis psavidis mentioned this pull request Feb 7, 2024
Closed
3 tasks
@psavidis psavidis force-pushed the 4002-add-java21-jenkins-support branch from acc4500 to 60009fa Compare February 9, 2024 10:55
@psavidis psavidis marked this pull request as ready for review February 9, 2024 10:56
@psavidis psavidis requested a review from yanavasileva February 9, 2024 10:56
@psavidis psavidis force-pushed the 4002-add-java21-jenkins-support branch from 6aea4b5 to 61fc355 Compare February 12, 2024 15:31
@psavidis
Copy link
Contributor Author

psavidis commented Feb 13, 2024 •
edited
Loading

The build failure is attributed to upgrading feel-scala from 1.6.2 to 1.7.5

  • The update breaks the test CustomFunctionTest#shouldThrowExceptionDueToDisabledVarargs ;
  • There is a change in behaviour of how the varargs evaluation behaves when you disable the varargs evaluation.
  • Created a ticket to move the problem there

The Review for Java 21 Support can continue normally and feel-scala upgrade will be done in another thread.

@psavidis psavidis force-pushed the 4002-add-java21-jenkins-support branch from a18a8aa to 8d7aa75 Compare February 13, 2024 14:34
@yanavasileva yanavasileva added the bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. label Feb 14, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@yanavasileva yanavasileva added bot:java-dependency-tree and removed bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. labels Feb 14, 2024
@github-actions GitHub Actions
Copy link

Dependency Tree Diff

diff -r /base/clients/java/client/dependencies.txt /pr/clients/java/client/dependencies.txt
16,17c16,17
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
43,44c43
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
<    org.mockito:mockito-inline:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-inline/4.3.1/mockito-inline-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
46c45
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/engine/dependencies.txt /pr/engine/dependencies.txt
41,42c41,42
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
106,107c106
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
<    org.mockito:mockito-inline:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-inline/4.3.1/mockito-inline-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
109c108
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/engine-dmn/engine/dependencies.txt /pr/engine-dmn/engine/dependencies.txt
14,15c14,15
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
28,29c28,29
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/engine-dmn/feel-scala/dependencies.txt /pr/engine-dmn/feel-scala/dependencies.txt
10,11c10,11
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
17,18c17,18
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/engine-plugins/spin-plugin/dependencies.txt /pr/engine-plugins/spin-plugin/dependencies.txt
21,22c21,22
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
44c44
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
46c46
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/engine-rest/engine-rest/dependencies.txt /pr/engine-rest/engine-rest/dependencies.txt
37,38c37,38
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
114c114
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
116c116
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/engine-rest/engine-rest-jakarta/dependencies.txt /pr/engine-rest/engine-rest-jakarta/dependencies.txt
29,30c29,30
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
48c48
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
50c50
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/engine-spring/core/dependencies.txt /pr/engine-spring/core/dependencies.txt
21,22c21,22
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
46c46
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
48c48
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/engine-spring/core-6/dependencies.txt /pr/engine-spring/core-6/dependencies.txt
25,26c25,26
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
49c49
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
51c51
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/spring-boot-starter/starter-client/spring/dependencies.txt /pr/spring-boot-starter/starter-client/spring/dependencies.txt
23,24c23
<    org.mockito:mockito-core:jar:5.7.0:test:/root/.m2/repository/org/mockito/mockito-core/5.7.0/mockito-core-5.7.0.jar
<    org.mockito:mockito-inline:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-inline/4.3.1/mockito-inline-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
diff -r /base/spring-boot-starter/starter-client/spring-boot/dependencies.txt /pr/spring-boot-starter/starter-client/spring-boot/dependencies.txt
41,42c41
<    org.mockito:mockito-core:jar:5.7.0:test:/root/.m2/repository/org/mockito/mockito-core/5.7.0/mockito-core-5.7.0.jar
<    org.mockito:mockito-inline:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-inline/4.3.1/mockito-inline-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
diff -r /base/spring-boot-starter/starter-webapp-core/dependencies.txt /pr/spring-boot-starter/starter-webapp-core/dependencies.txt
88,89c88
<    org.mockito:mockito-core:jar:5.7.0:test:/root/.m2/repository/org/mockito/mockito-core/5.7.0/mockito-core-5.7.0.jar
<    org.mockito:mockito-inline:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-inline/4.3.1/mockito-inline-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
diff -r /base/test-utils/assert/core/dependencies.txt /pr/test-utils/assert/core/dependencies.txt
18,19c18
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
<    org.mockito:mockito-inline:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-inline/4.3.1/mockito-inline-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
21c20
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/webapps/assembly/dependencies.txt /pr/webapps/assembly/dependencies.txt
28,29c28,29
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
73,74c73
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
<    org.mockito:mockito-inline:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-inline/4.3.1/mockito-inline-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
76c75
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/webapps/assembly-jakarta/dependencies.txt /pr/webapps/assembly-jakarta/dependencies.txt
27,28c27,28
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
48,49c48
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
<    org.mockito:mockito-inline:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-inline/4.3.1/mockito-inline-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
51c50
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar
diff -r /base/webapps/dependencies.txt /pr/webapps/dependencies.txt
13,14c13,14
<    net.bytebuddy:byte-buddy-agent:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.7/byte-buddy-agent-1.12.7.jar
<    net.bytebuddy:byte-buddy:jar:1.12.7:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.12.7/byte-buddy-1.12.7.jar
---
>    net.bytebuddy:byte-buddy-agent:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy-agent/1.14.11/byte-buddy-agent-1.14.11.jar
>    net.bytebuddy:byte-buddy:jar:1.14.11:test:/root/.m2/repository/net/bytebuddy/byte-buddy/1.14.11/byte-buddy-1.14.11.jar
34,35c34
<    org.mockito:mockito-core:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-core/4.3.1/mockito-core-4.3.1.jar
<    org.mockito:mockito-inline:jar:4.3.1:test:/root/.m2/repository/org/mockito/mockito-inline/4.3.1/mockito-inline-4.3.1.jar
---
>    org.mockito:mockito-core:jar:5.10.0:test:/root/.m2/repository/org/mockito/mockito-core/5.10.0/mockito-core-5.10.0.jar
37c36
<    org.objenesis:objenesis:jar:3.2:test:/root/.m2/repository/org/objenesis/objenesis/3.2/objenesis-3.2.jar
---
>    org.objenesis:objenesis:jar:3.3:test:/root/.m2/repository/org/objenesis/objenesis/3.3/objenesis-3.3.jar

yanavasileva
yanavasileva requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work. Please check the review hints below:

.ci/config/stage-types.yaml Outdated Show resolved Hide resolved
.ci/config/stage-types.yaml Outdated Show resolved Hide resolved
engine/src/main/java/org/camunda/bpm/engine/impl/interceptor/CommandCounterInterceptor.java Outdated Show resolved Hide resolved
engine/src/main/java/org/camunda/bpm/engine/impl/util/ClassNameUtil.java Outdated Show resolved Hide resolved
psavidis and others added 8 commits February 15, 2024 13:03
@psavidis
chore(.ci/config): Add Java 21 Stages to Jenkins Files
33a6154 
Related-to: #4002
@psavidis
chore(engine): Fix CommandCounterInterceptor Lambda Checks
f63cc58 
Context: Java 21 Lambdas have suffix `$$Lambda` instead of `$$Lambda$` for previous JDKs
Solution: Keep legacy behaviour conditionally & apply the new check for java versions > 21
@psavidis
chore(camunda-external-task-client): Fix Tests
54884d3 
This commit fixes the failing build on Jenkins. First tests that were failing the build were on the external client.
Other tests in the project suffered from the same issue, the replacement of `mockito-inline` dependency by `mockito-core`

- Update to Mockito 5.10.0
- After Mockito `5.3.0` release, `mockito-inline` is incorporated in `mockito-core`
@psavidis
chore(parent): Upgrade feel-scala
17a3af4 
- feel-scala is upgraded from 1.16.2 to 1.17.5
- The context of this change is use an artifact that supports building with JDK 21
@psavidis
chore(engine): Replace mockito-inline with mockito-core
b136c7c
@psavidis
Revert "chore(parent): Upgrade feel-scala"
fceac2e 
This reverts commit 61fc355.
@psavidis @yanavasileva
Apply suggestions from code review
c8a3a8b 
Co-authored-by: yanavasileva <[email protected]>
@psavidis @yanavasileva
Apply suggestions from code review
7de8e0f 
Co-authored-by: yanavasileva <[email protected]>
@psavidis psavidis force-pushed the 4002-add-java21-jenkins-support branch from e45f23a to 7de8e0f Compare February 15, 2024 11:03
yanavasileva
yanavasileva approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for incorporating the feedback.

@psavidis psavidis merged commit 744675a into master Feb 16, 2024
3 of 4 checks passed
@psavidis psavidis deleted the 4002-add-java21-jenkins-support branch February 16, 2024 08:26
psavidis added a commit that referenced this pull request Feb 26, 2024
@psavidis
chore(.ci/config): Add JDK 21 Build Support
7f1549c 
Notable Changes:

- Java 21 Lambdas have suffix `$$Lambda` instead of `$$Lambda$` for previous JDKs. With this commit, `CommandCounterInterceptor` checks for the first instead as a subset that will work for all JDK versions and will be more conservative filtering.
- `mockito-inline` is replaced with `mockito-core`
- This commit adds Java 21 build stages to the CI

Co-authored-by: yanavasileva
Co-authored-by: petros.savvidis
Related-to: #4056, #4002
psavidis added a commit that referenced this pull request Mar 4, 2024
@psavidis
chore(.ci/config): Add JDK 21 Build Support
8fca15d 
Notable Changes:

- Java 21 Lambdas have suffix `$$Lambda` instead of `$$Lambda$` for previous JDKs. With this commit, `CommandCounterInterceptor` checks for the first instead as a subset that will work for all JDK versions and will be more conservative filtering.
- `mockito-inline` is replaced with `mockito-core`
- This commit adds Java 21 build stages to the CI

Co-authored-by: yanavasileva
Co-authored-by: petros.savvidis
Related-to: #4056, #4002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavasileva yanavasileva yanavasileva approved these changes

Assignees

@psavidis psavidis

Labels
ci:e2e Runs the frontend end-to-end tests. ci:jdk Runs the builds for all supported Java versions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psavidis @yanavasileva