fix(webapps/tasklist): render task if no filter exists #4926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venetrius
commented
Feb 7, 2025
| @@ -140,7 +140,7 @@ module.exports = [ | |||
| 'searchQuery', | |||
| function(currentFilter, searchQuery) { | |||
| if (!currentFilter) { | |||
| return null; | |||
| return angular.copy(searchQuery); | |||
There was a problem hiding this comment.
If no filter exists we still need to return the searchQuery otherwise taskId will be removed from the $location
1 task
This reverts commit 0917265.
venetrius
force-pushed
the
4793-opening-task-from-link-does-not-work
branch
from
8dcf4b9 to
40d9778
Compare
venetrius
commented
Feb 7, 2025
| @@ -179,7 +179,7 @@ module.exports = [ | |||
| if (oldQuery.id && oldQuery.id !== taskListQuery.id) { | |||
| clearSelectedTask(); | |||
| } | |||
| } else { | |||
| } else if (!angular.equals(oldQuery, {})) { | |||
There was a problem hiding this comment.
Don't clear the selected task if the new and the old search are both empty.
tasso94
approved these changes
Feb 14, 2025
venetrius
added
bot:backport:7.20
|
Successfully created backport PR for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: /issues/4793