Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify filtering list of contexts where some part is null or non-existing #700

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

remcowesterhoud
Copy link
Contributor

Description

This PR adds some testcases to verify filtering over a list of contexts works as intended. It focuses on cases where something in the contexts, or filter is non-existing or null.

Related issues

closes #582

This commit adds some testcases to verify filtering over a list of contexts works as intended. It focuses on cases where something in the contexts, or filter is non-existing or null.
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

LGTM 👍

Copy link
Member

@koevskinikola koevskinikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@remcowesterhoud remcowesterhoud merged commit 01c12cd into main Aug 18, 2023
@remcowesterhoud remcowesterhoud deleted the 582_context_filter_null_comparisons branch August 18, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle non-existing variables and context entries gracefully in comparison and filter expressions
3 participants