feat: create new assert function #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
saig0
requested changes
Sep 7, 2023
src/main/scala/org/camunda/feel/impl/builtin/BooleanBuiltinFunctions.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/camunda/feel/impl/interpreter/FeelInterpreter.scala
Outdated
Show resolved
Hide resolved
src/test/scala/org/camunda/feel/impl/builtin/BuiltinFunctionsTest.scala
Outdated
Show resolved
Hide resolved
|
@nicpuppa it seems that the SLA bot doesn't like your commits. Please check if the email address of the commits match your GitHub account. |
nicpuppa
force-pushed
the
675-new-assert-function
branch
from
b3e699b to
af1069a
Compare
|
Hi @saig0 thanks for the review 🚀 I applied all the suggestions, please have another look 👀 Sorry for the CLA, new pc 😂 |
saig0
requested changes
Sep 8, 2023
src/main/scala/org/camunda/feel/impl/interpreter/FeelInterpreter.scala
Outdated
Show resolved
Hide resolved
Created newbuilt-in assert function to verify that a certain condition is met
Updated the FeelInterpreter in order to return a ValError (instead of ValNull) if the condition of the new assert function is not fulfilled Added a new evaluation failure type ASSERT_FAILURE, for every evaluation error of the new assert() function Added also a checker for wrapped function, if an ASSERT_FAILURE is raised during the evaluation an error is returned instead of null
Created new tests to verify the correct behaviour of the new assert function Use the new FeelEngineTest and EvaluationResultMatchers to a better readability refactor: remove unused imports
Make sure that even if the assert() function is wrapped inside other functions the engine should return the error message provided by the user Adjust the tests to verify the logic above
nicpuppa
force-pushed
the
675-new-assert-function
branch
from
261bf5e to
93a3b23
Compare
|
Applied all suggestions, please have another look @saig0 👀 |
Ignore test cases due to: #695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create new
assert(value, condition)function in order to allow users to verify if a variable met a certain condition, and return an error if the condition is not fulfilled. This function should help users to migrate to 8.3 easily if they rely on validation error.Users can provide also a custom error message by
assert(value, condition, cause)Related issues
closes #675