build: run TC tests with Java 21 #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We specify the release version to be Java 8 when running the tests, which ensures that we will catch issues where use APIs > JDK 8, or syntax that is unsupported on JDK 8, while still allowing us to use a build environment (including plugins) for greater versions. The one downside is we won't detect anymore if we pull in transitive dependencies > JDK 8, but this should be detected separately.
npepinpe
force-pushed
the
np-run-with-java-21
branch
from
00f5e67 to
16ca841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We specify the release version to be Java 8 when running the tests, which ensures that we will catch issues where use APIs > JDK 8, or syntax that is unsupported on JDK 8, while still allowing us to use a build environment (including plugins) for greater versions.
The one downside is we won't detect anymore if we pull in transitive dependencies > JDK 8, but this should be detected separately.