Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: configure setuptools via pyproject.toml #292

Closed
wants to merge 13 commits into from
Closed

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Mar 22, 2024

Per https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html. We've done this for most of our other projects now -- it enables some consolidation of tool configurations, which is nice.

korikuzma and others added 12 commits November 11, 2022 11:14
- Updated dependencies (civicpy, normalizers, ga4gh)
- `Harvester` base class
  - Remove instance var `assertions`
  - Create timestamped harvester json if no filename given (now includes empty string)
- `CIViCHarvester` 
  - Major cleanup. We will only exclude civic fields that start with `_` or `partial`  
  - We now harvest civic molecular profiles
  - We no longer get `civic_actionability_score` and `variant_groups`
- `OncoKBHarvester`
  - Use enum values for api endpoints 
- `metakb.main`
  - Use Path for `/api/v2/search/{id}` rather than Query
- `metakb.normalizers`
  - Rename instance var `variation_normalizer` --> `variation_query_handler`  
  - Allow for query handler instances to be passed as parameters
- `CIViCTransform` : Updates from civicpy 3.0
  - Include molecular profile ID to variant ID mapping
  - Assertion's now have `assertion_type`
  - `drugs` --> `therapies`
- `OncoKBTransform`
  - `uuid` for drug returned `None`, so switched to using `ncitCode` for the therapy descriptor mappings
- `setup.cfg`
  - license-file --> license_file in setup.cfg
- Tests
  - In test_database.py::test_variation_rules, I removed a check since we now support copy number variation from {GENE} Amplification queries
  - Updated tests to reflect source changes 
- `metakb.cli`
  - Added `--update_from_remote` for civicpy cache
- Remove from version.py
- Remove from ServiceMeta class
- Update permissions for cool-seq-tool
- Update python version to 3.11
- Fix unzipping seqrepo
- Handling null civic therapy ncit_id's
- Only look at accepted assertions for civic
* Followed https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
  * Did not include [Signing the distribution packages](https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#signing-the-distribution-packages)
  * In `publish-to-pypi`, removed `if: startsWith(github.ref, 'refs/tags/')  # only publish to PyPI on tag pushes` since we only make a release when a GH release is created.
@jsstevenson jsstevenson added the priority:medium Medium priority label Mar 22, 2024
@jsstevenson jsstevenson changed the title build: use for build configs build: configure setuptools via pyproject.toml Mar 22, 2024
@jsstevenson jsstevenson changed the base branch from main to epic-231 March 22, 2024 19:16
@jsstevenson
Copy link
Member Author

(need to figure out proper PR here, may need to rebase, etc)

@jsstevenson jsstevenson mentioned this pull request Mar 22, 2024
@jsstevenson jsstevenson deleted the pyproject branch March 22, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants