feat!: move ViccNormalizerDataExtension to mappings
#425
+470
−340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
added
enhancement
katiestahl
approved these changes
Jan 28, 2025
mcannon068nw
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@katiestahl @mcannon068nw keeping as draft until #429 is merged, but this is ready for review. Needed for VarCat MVP / ClinVar Submission.
close #418
mappingsmappingswill have an extension with namevicc_normalizer_priorityif this concept mapping came from the VICC normalizers. When the value isTrue, this means that the concept mapping is the priority code / label for the merged record. When the value isFalsethis means that the concept mapping comes from the merged record's mappings.Open to suggestions on better extension name / value.