-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle input not enclosed in quotes in "Deploy to AKS" and "Deploy to EKS" actions #1035
Conversation
…ditional whitespace
Nice to see this worked on @mvlassis! With a quick glance we should improve the following:
To mitigate the above I suggest we create a new script under |
@kimwnasptd Totally agreed! Also, peeking at the 2 actions, there is a lot of overlap which can potentially be condensed. Should we create a task for merging all the logic into a new Python script under |
I'd say it's OK for now, we'll either way start relying less and less on these actions once SolQA picks up testing. So no need to focus more time on these I would propose |
Closes #1034
This PR updates the
deploy-to-aks.yaml
anddeploy-to-eks.yaml
scripts to be able to handle values not enclosed in quotes. This is achieved by adding apreprocess-input
job that processes the input to add quote characters and create a valid JSON array. An example of a valid input is:Additionally, the
preprocess-input
job removes space characters, this means that input like this is also handled properly: