Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle input not enclosed in quotes in "Deploy to AKS" and "Deploy to EKS" actions #1035

Merged
merged 19 commits into from
Sep 5, 2024

Conversation

mvlassis
Copy link
Contributor

Closes #1034

This PR updates the deploy-to-aks.yaml and deploy-to-eks.yaml scripts to be able to handle values not enclosed in quotes. This is achieved by adding a preprocess-input job that processes the input to add quote characters and create a valid JSON array. An example of a valid input is:

1.8,1.9,latest

Additionally, the preprocess-input job removes space characters, this means that input like this is also handled properly:

1.8, 1.9, latest

@mvlassis mvlassis requested a review from a team as a code owner August 23, 2024 11:18
@kimwnasptd
Copy link
Contributor

Nice to see this worked on @mvlassis!

With a quick glance we should improve the following:

  1. The script is duplicated in the 2 different actions
  2. It's using bash that make it a bit hard to read

To mitigate the above I suggest we create a new script under scripts/gh-actions/pasre_versions.py and use this common script for both places (open to suggestions on the folder structure of course)

@mvlassis
Copy link
Contributor Author

mvlassis commented Sep 2, 2024

@kimwnasptd Totally agreed! Also, peeking at the 2 actions, there is a lot of overlap which can potentially be condensed. Should we create a task for merging all the logic into a new Python script under scrtips that will contain this logic into separate functions?

@kimwnasptd
Copy link
Contributor

I'd say it's OK for now, we'll either way start relying less and less on these actions once SolQA picks up testing.

So no need to focus more time on these I would propose

@kimwnasptd kimwnasptd merged commit f54e015 into main Sep 5, 2024
5 checks passed
@kimwnasptd kimwnasptd deleted the manos-cloud-tests-enhancement branch September 5, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receive input not enclosed in quotes "Deploy to AKS" and "Deploy to EKS" actions
2 participants