Make sure the charm can be installed bionic #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because that's an unexpected usage of `envdir` in `tox < 4` and is removed in `tox >= 4`.
chanchiwai-ray
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza,
rgildein and
Deezzir
|
Looks like the old juju-local isn't working on bionic (or need specify care for LXD setup). The new juju-local does not have bionic support |
|
The failing tests are likely due to this bug: https://bugs.launchpad.net/juju/+bug/1926192 (experiencing it in local tests) |
Test cannot be started due to https://bugs.launchpad.net/juju/+bug/1926192. This reverts commit 7447a77.
chanchiwai-ray
changed the title
|
Changed the scope since we can't test on bionic due to the above bug mentioned (locally and also in CI). Still this PR is fixing the bug that it failed to install on bionic because latest
|
Pjack
approved these changes
Nov 26, 2024
aieri
approved these changes
Nov 26, 2024
jneo8
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an regression of #68
Add bionic into gate bundleskipped due to https://bugs.launchpad.net/juju/+bug/1926192envdirfromtox.inias that's an unexpected usage ofenvdirand is removed intox >= 4