[DPE-4867] - Release new rock and fix broken CI #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
force-pushed
the
update-rock-ci
branch
from
1ad3ddd to
332cae6
Compare
MiaAltieri
force-pushed
the
update-rock-ci
branch
2 times, most recently
from
22fefb0 to
bd8c1e1
Compare
MiaAltieri
force-pushed
the
update-rock-ci
branch
4 times, most recently
from
c5bfb2a to
9a88163
Compare
MiaAltieri
force-pushed
the
update-rock-ci
branch
2 times, most recently
from
35824a9 to
9c7ca20
Compare
MiaAltieri
changed the title
MiaAltieri
force-pushed
the
update-rock-ci
branch
5 times, most recently
from
8b58667 to
b3f6088
Compare
Gu1nness
approved these changes
Jul 15, 2024
MiaAltieri
force-pushed
the
update-rock-ci
branch
from
b3f6088 to
2cc344f
Compare
MiaAltieri
force-pushed
the
update-rock-ci
branch
4 times, most recently
from
e2de378 to
759f9ee
Compare
MiaAltieri
force-pushed
the
update-rock-ci
branch
from
759f9ee to
868e2b5
Compare
MiaAltieri
force-pushed
the
update-rock-ci
branch
from
eaf3fd8 to
8345511
Compare
MiaAltieri
force-pushed
the
update-rock-ci
branch
from
8345511 to
5071494
Compare
MiaAltieri
force-pushed
the
update-rock-ci
branch
from
0e1b19a to
aabced3
Compare
Mehdi-Bendriss
approved these changes
Jul 19, 2024
| @@ -45,7 +45,7 @@ commands = | |||
| bash -ec 'microk8s ctr image import {env:name}_*-$(yq .base rockcraft.yaml | \ | |||
| cut -c 8-)_edge_amd64.rock --base-name {env:registry_namespace}/{env:name}' | |||
| bash -ec 'if ! [ -d operator ]; then git clone --single-branch --branch {env:branch} {env:repo} operator; fi' {posargs} | |||
| tox --workdir operator -c operator -e ha-integration -- --keep-models | |||
| tox --workdir operator -c operator -e integration -- tests/integration/ha_tests/test_ha.py --deselect tests/integration/ha_tests/test_ha.py::test_network_cut | |||
There was a problem hiding this comment.
Note - we should remember to re-enable the network cut tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
How is the integration portion of CI out of date
The CI was only ever meant to test these three test from Charmed MongoDB K8s
However, Charmed MongoDB K8s own CI / tox file got updated a few months ago to a different format. This meant that the rock was (incorrectly) attempting to run all integration tests. Instead of just the three it was meant to test.
Solution
Future work
HA tests on network cut tests need to be re-enabled