Add 1.16.3 #12
Merged
Add 1.16.3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're adding Rock images for Cilium 1.16.3.
petrutlucian94
force-pushed
the
lpetrut/1_16_3
branch
from
e716e6c to
5a80a64
Compare
|
Building cilium-envoy currently fails because of a checksum validation error, need to investigate further. |
|
We're hitting this: envoyproxy/envoy#36563 |
Some dependency checksums have changed, which causes the envoy build to fail. We'll apply a patch that updates these checksums.
berkayoz
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Great work, I believe in 1.16 Cilium switched to LLVM 17 and Go 1.22. Can we check for dependencies to make sure they are matching? You can refer to https://github.com/cilium/cilium/tree/v1.16.3/images
petrutlucian94
force-pushed
the
lpetrut/1_16_3
branch
from
d233c26 to
02ea635
Compare
|
@berkayoz one problem though: there are no llvm-17 packages for ubuntu 22.04, we'll have to add the repos or switch to 24.04, which may break other dependencies. |
We're updating the cilium dependencies according to the upstream 1.16.3 release.
petrutlucian94
force-pushed
the
lpetrut/1_16_3
branch
from
02ea635 to
8c027b8
Compare
berkayoz
reviewed
Nov 12, 2024
The "OUTPUT" parameter isn't properly handled by the bpftool make script, so we'll copy it over from the default directory.
petrutlucian94
force-pushed
the
lpetrut/1_16_3
branch
from
ae63931 to
eaafef3
Compare
berkayoz
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding Rock images for Cilium 1.16.3.