-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add COS integration and metric logs #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 78 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
37 | 2 | 39 | 0 |
Click to see the invalid file list
- content-cache/lib/charms/grafana_agent/v0/cos_agent.py
- lib/charms/grafana_agent/v0/cos_agent.py
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor doc comments.
Co-authored-by: Ali UĞUR <[email protected]>
For your next PR, please do the public interface first and get it reviewed by the allocated senior reviewer. You can read more in ISD062 |
Test coverage for 6361378
Static code analysis report
|
Overview
cos-agent
integration. This will enable ingestion of logs on the charm to COS.Rationale
The two changes will allow metrics to be ingested to COS for a dashboard to be built.
Checklist
src-docs
urgent
,trivial
,complex
)