Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize rockcraft build #13

Merged
merged 9 commits into from
Aug 22, 2024

Conversation

maci3jka
Copy link

@maci3jka maci3jka commented Aug 7, 2024

Currently, for each change in the rockcraft repo, we publish the current state of rockcraft files and run tests on them even if files haven’t changed. We need to build only changed files but run tests on all rock images.

The PR updates pushed images after the build to only those modified rocks and also, bump the rockcraft version which fixes the CI build.

KU-1195

@maci3jka maci3jka requested review from bschimke95 and a team August 7, 2024 18:38
@maci3jka maci3jka changed the title Update pull_request.yaml after KU-1195 Update pull_request.yaml to skip unnecessary builds Aug 8, 2024
@maci3jka maci3jka requested a review from berkayoz August 16, 2024 08:20
@maci3jka maci3jka changed the title Update pull_request.yaml to skip unnecessary builds Optimize rockcraft build Aug 21, 2024
.gitignore Outdated Show resolved Hide resolved
@maci3jka
Copy link
Author

merge #14 before

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run-tests need to be moved as well. Otherwise the CI fails.

@maci3jka maci3jka force-pushed the story/KU-1195/update-workflow-after-changes branch from bd86ef9 to ae01955 Compare August 22, 2024 06:18
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit 1ecd13b into main Aug 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants