-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize rockcraft build #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maci3jka
changed the title
Update pull_request.yaml after KU-1195
Update pull_request.yaml to skip unnecessary builds
Aug 8, 2024
maci3jka
changed the title
Update pull_request.yaml to skip unnecessary builds
Optimize rockcraft build
Aug 21, 2024
bschimke95
reviewed
Aug 21, 2024
maci3jka
commented
Aug 21, 2024
bschimke95
reviewed
Aug 21, 2024
merge #14 before |
bschimke95
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run-tests
need to be moved as well. Otherwise the CI fails.
maci3jka
force-pushed
the
story/KU-1195/update-workflow-after-changes
branch
from
August 22, 2024 06:18
bd86ef9
to
ae01955
Compare
bschimke95
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for each change in the rockcraft repo, we publish the current state of rockcraft files and run tests on them even if files haven’t changed. We need to build only changed files but run tests on all rock images.
The PR updates pushed images after the build to only those modified rocks and also, bump the rockcraft version which fixes the CI build.
KU-1195