Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.11.3 image #17

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add 1.11.3 image #17

merged 1 commit into from
Nov 8, 2024

Conversation

petrutlucian94
Copy link
Contributor

We're adding a new rockcraft definition for the 1.11.3 coredns version.

We're adding a new rockcraft definition for the 1.11.3 coredns
version.
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we create a card to update update_version.yaml as we've switched to the folder per version approach?

@berkayoz berkayoz merged commit 89d70c5 into main Nov 8, 2024
11 of 15 checks passed
@addyess
Copy link
Contributor

addyess commented Nov 8, 2024

@petrutlucian94 please fix the github action that's now broken.
https://github.com/canonical/coredns-rock/blob/main/.github/workflows/update_version.yaml

it used to update the branch's ONLY rockcraft.yaml. Now it seems when we discover a new version, we need to make a new folder and rockcraft.yaml etc...

@addyess addyess deleted the lpetrut/1_11_3 branch December 2, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants