Add itest for multi unit alerts #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abuelodelanada
approved these changes
Mar 10, 2022
No pebble socket. Possible juju failure. Rerunning |
This passed locally but now here fails for i.e. seems like no |
|
This test is flaky because the charm I uploaded to edge has a stray rule file: |
mmanciop
reviewed
Mar 11, 2022
mmanciop
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an itest that addresses canonical/prometheus-k8s-operator#239:
Now that
juju_unitis no longer added to rule files, this test confirms that alerts still fire per unit (not only from the leader unit), and are correctly labeled as such.