Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: improve error message for invalid architectures #98

Merged
merged 3 commits into from
Feb 3, 2025
Merged

style: improve error message for invalid architectures #98

merged 3 commits into from
Feb 3, 2025

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented Jan 31, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?

Update docstrings to include :raises:, improve error message presentation.

Fixes canonical/craft-application#629 (comment)

@mr-cal mr-cal requested review from a team and removed request for a team January 31, 2025 19:09
@mr-cal mr-cal marked this pull request as draft January 31, 2025 19:29
@mr-cal mr-cal changed the title docs: add :raises: to docstrings style: improve error message for invalid architectures Jan 31, 2025
@mr-cal mr-cal marked this pull request as ready for review January 31, 2025 19:56
@mr-cal mr-cal mentioned this pull request Jan 31, 2025
Closed
@mr-cal mr-cal requested review from tigarmo and lengau January 31, 2025 19:57
@mr-cal mr-cal requested a review from tigarmo January 31, 2025 20:49
tigarmo
tigarmo approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

lengau
lengau reviewed Feb 3, 2025
View reviewed changes
docs/reference/changelog.rst Outdated Show resolved Hide resolved
@mr-cal
docs: make a minor version bump
9d474a0 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
Copy link
Contributor Author

mr-cal commented Feb 3, 2025

@lengau - I'll need you to land this.

@lengau lengau merged commit 9e86439 into main Feb 3, 2025
13 checks passed
@lengau lengau deleted the work/docstring branch February 3, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve validation error presentation for invalid architectures in project models
3 participants
@mr-cal @tigarmo @lengau