Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to 12 factor charm #264

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Add support to 12 factor charm #264

merged 3 commits into from
Nov 8, 2023

Conversation

jpmartinspt
Copy link
Contributor

@jpmartinspt jpmartinspt commented Oct 24, 2023

Done

Add support to 12 factor charm

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8037
  • Run through the following QA steps
  • [List additional steps to QA the new features or prove the bug has been resolved]

Issue / Card

Fixes #

Screenshots

[if relevant, include a screenshot]

@webteam-app
Copy link

Demo starting at https://dqlite-io-264.demos.haus

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #264 (23e658b) into main (bf9b768) will not change coverage.
Report is 9 commits behind head on main.
The diff coverage is n/a.

❗ Current head 23e658b differs from pull request most recent head d149729. Consider uploading reports for the commit d149729 to get more accurate results

@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   76.31%   76.31%           
=======================================
  Files           2        2           
  Lines          38       38           
=======================================
  Hits           29       29           
  Misses          9        9           
Flag Coverage Δ
python 76.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jpmartinspt jpmartinspt force-pushed the build-and-publish-image branch from 96b279b to d5219f7 Compare October 24, 2023 19:37
@jpmartinspt jpmartinspt force-pushed the build-and-publish-image branch from d5219f7 to ff03ea7 Compare November 7, 2023 12:35
@jpmartinspt jpmartinspt force-pushed the build-and-publish-image branch from ff03ea7 to 12f2178 Compare November 8, 2023 08:22
@jpmartinspt jpmartinspt changed the title WIP - Add push step to workflow Add support to 12 factor charm Nov 8, 2023
Copy link
Contributor

@albertkol albertkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@albertkol albertkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jpmartinspt jpmartinspt merged commit 5e8d2fa into main Nov 8, 2023
@jpmartinspt jpmartinspt deleted the build-and-publish-image branch November 8, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants