Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: implement createRegular and add it to the reference app #1

Draft
wants to merge 52 commits into
base: master
Choose a base branch
from
Draft

feature: implement createRegular and add it to the reference app #1

wants to merge 52 commits into from

Conversation

mattkae
Copy link

@mattkae mattkae commented Oct 24, 2024 •
edited
Loading

This pull request:

  • Lays the foundational data models for multi window Flutter applications
  • Implements createRegular for the creation of regular toplevel windows
  • Add the multi_window_ref_app example application to the project to demonstrate the creation of a regular window
  • Add an initial unit test for the creation of regular windows
  • Adapt the runner code of a typical single window application for multi window

image

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@mattkae mattkae changed the title feature: implement createRegularWindow and add it to the reference app feature: implement createRegular and add it to the reference app Oct 24, 2024
mattkae and others added 28 commits January 7, 2025 18:48
@mattkae
feature: implement createRegularWindow and add it to the reference app
fcf1f96
@mattkae
wip: refactor of the foundational code
3e44a59
@mattkae
wip: refactored the mutlti window reference app to use new API
a4f99b7
@mattkae
wip: able to create windows in the reference application again
529b9ea
@mattkae
Selection and rerenders are functioning appropriately
4dd2d95
@mattkae
Able to remove an application, albeit with some bugs + refactored how…
86d79f3 
… settings are donw
@mattkae
Able to add and remove windows
6c79bf9
@mattkae
All windows are now showing in the list
4115b85
@mattkae
Added the ability to listen for errors and respond to them accordingly
2908877
@mattkae
Refactored window.dart to be more concise for the initial PR
40ad0d6
@mattkae
Making the WindowMetadata public and only refresing the relevant fiel…
e39a6e6 
…ds when settings change
@mattkae
RegularWindowMetadata and WindowMetadata are useless
5041013
@mattkae
The future should be set in setState
20bbd5c
@mattkae
Properly handling the event where we need to destroy the widget durin…
273b31a 
…g a dispose
@mattkae
Fix issue where setState returned a future
bfd8974
@mattkae
setState is ssynchronous, whoops!
10a91d1
@mattkae
It does not make sense for the modify method to be an override since …
25ecf07 
…different window types will have different values
@mattkae
Fixed issue where we might accidentally dispose of a window twice
df87dfd
@mattkae
bugfix: able to select the initial wndow in the table
77c9e39
@mattkae
Reimplement the rotating cube in the demo app
d1d56fe
@mattkae
PR feedback
e2078d3
@mattkae
Rendering correct text
2dc3a7a
@mattkae
Reverting back to the old runner code
9191329
@mattkae
Update runner code to work with the latest & greatest
bf0ffb4
@hbatagelo @mattkae
Add command-line option for multi-window support and refactor runner …
009c2e0 
…code
@mattkae
feature: adding full client-side tests for regular window creation (#14)
bbb45fb 
feature: adding full client-side tests for regular window creation
@hbatagelo
Add foundational support for Windows multi-window in the engine (#15)
da7c7a3
@hbatagelo
Refactor method channel for regular windows
495eace
hbatagelo and others added 24 commits January 21, 2025 17:25
@hbatagelo
Review feedback + align code style with guidelines
3bdc07f
@hbatagelo
Add FML as a dependency to common_cpp_core; fix incorrect include
12c4f47
@hbatagelo
Improve comments and code style consistency
0751180
@mattkae
Merge pull request #19 from canonical/refactor-method-channel
1bff803 
Refactor method channel for regular windows
@mattkae
Refactor regular windows (#20)
ba564ea 
* refactor: the RegularWindowController now holds all initial values and is solely responsible for creating and destroying a window

* Updated multi window reference app and window tests
@mattkae
refactor: remove references to WindowingApp from the window.dart API (#…
df92dd1 
…21)

* refactor: remove references to WindowingApp from the window.dart API

* bugfix: notify listeners when values change on a window controller
@mattkae
refactor: raw create/destroy methods are now hidden + renamed WindowC…
9bd57f3 
…ontext to WindowControllerContext and made it provide the controller (#22)
@mattkae
feature: implemented modifyRegular + fixed a bug where a widget tree …
db66141 
…was mandatory on accident
@mattkae
feature: tidy up all of the documentation around regular windows + si…
5758182 
…mplify parts of the API (#25)
@mattkae
refactor: distinguish a WindowCreationResult from a particular Regula…
8793c83 
…rWindowCreationResult
@mattkae
minor: fix spelling mistake
f32d553
@mattkae
git is confused and not recognizing my pushes...?
b4a3c73
@hbatagelo
Add support for modifyRegular in the embedder and update examples/tests
b44e867
@hbatagelo
Better ModifyRegularWindow test
2b9ea14
@hbatagelo
Add inequality operator for flutter::Size
3a08fb9
@hbatagelo
Add SetState and remove unused GetState
6bf2639
@hbatagelo
Log error messages during window creation, window change, and destruc…
7fabdcd 
…tion
@hbatagelo
Split up tests for modifying the window and add a test for changing t…
0dc1c6b 
…he window state
@mattkae
Merge pull request #24 from canonical/regular-windows-modify
6ca09cd 
feature: implemented modifyRegular + fixed a bug where a widget tree was mandatory on accident
@mattkae
Merge remote-tracking branch 'upstream/master' into foundation
9bcf223
@mattkae
example: adding a modificatione example to the multi window reference…
6cff1dd 
… app
@mattkae
Merge pull request #28 from canonical/example/adding-edit
8fbad3a 
example: adding a modificatione example to the multi window reference app
@hbatagelo
Use kBadArgumentsError
b902fa5
@mattkae
feedback: WindowControllerContext.of now returns the WindowController…
72d71d6 
… instead of the context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattkae @hbatagelo