Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dashboard utils (part 2) #373

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Refactor dashboard utils (part 2) #373

merged 2 commits into from
Jan 15, 2025

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Jan 15, 2025

Following up on #370, as part of simplifying #363.
This PR introduces no functional changes.

@sed-i sed-i marked this pull request as ready for review January 15, 2025 21:20
@sed-i sed-i requested a review from a team as a code owner January 15, 2025 21:20
Abuelodelanada
Abuelodelanada approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Abuelodelanada Abuelodelanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/charms/grafana_k8s/v0/grafana_dashboard.py Show resolved Hide resolved
@sed-i sed-i merged commit 610a08b into main Jan 15, 2025
13 checks passed
@sed-i sed-i deleted the feature/refactor-load-dir branch January 15, 2025 22:11
@sed-i sed-i mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abuelodelanada Abuelodelanada Abuelodelanada approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sed-i @Abuelodelanada