Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design the _name in Strategy class. #124

Closed
jneo8 opened this issue Dec 5, 2023 · 0 comments · Fixed by #167
Closed

Re-design the _name in Strategy class. #124

jneo8 opened this issue Dec 5, 2023 · 0 comments · Fixed by #167
Labels
enhancement New feature or request
Milestone
23.10.4

Comments

@jneo8
Copy link
Contributor

jneo8 commented Dec 5, 2023

Because the needed to provide three different IPMI strategies in one IPMIStrategy class, it's not make sense to separate them into three different classes or just putting one of them in _name attribute.

We need to re-design this part.
@jneo8 jneo8 added this to the 23.10.1 milestone Dec 5, 2023
@jneo8 jneo8 mentioned this issue Dec 5, 2023
Merged
@jneo8 jneo8 modified the milestones: 23.10.1, 23.10.2 Dec 5, 2023
@jneo8 jneo8 modified the milestones: 23.10.2, 23.10.3 Dec 14, 2023
@Pjack Pjack modified the milestone: 23.10.3 Dec 26, 2023
@Pjack Pjack added the enhancement New feature or request label Dec 26, 2023
@Pjack Pjack modified the milestones: 23.10.3, 23.10.4 Jan 30, 2024
jneo8 added a commit to jneo8/hardware-observer-operator that referenced this issue Feb 20, 2024
@jneo8
refactor: Split IPMIStrategy to sensor, sel, and dcmi strategies
99d50a2 
Fix canonical#124
@jneo8 jneo8 mentioned this issue Feb 20, 2024
Merged
jneo8 added a commit that referenced this issue Feb 22, 2024
@jneo8
refactor: Split IPMIStrategy to sensor, sel, and dcmi strategies (#167)
2c876be 
Fix #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
23.10.4
Development

Successfully merging a pull request may close this issue.

refactor: Split IPMIStrategy to sensor, sel, and dcmi strategies jneo8/hardware-observer-operator
2 participants
@Pjack @jneo8