Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Split IPMIStrategy to sensor, sel, and dcmi strategies #167

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented Feb 20, 2024

Fix #124

@jneo8 jneo8 requested review from a team, Pjack, aieri, agileshaw and rgildein February 20, 2024 03:39
Copy link

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sudeephb sudeephb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change.

@jneo8 jneo8 merged commit 2c876be into canonical:master Feb 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-design the _name in Strategy class.
3 participants