Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplication in metric names for failed collectors #125

Closed
dashmage opened this issue Dec 5, 2023 · 0 comments · Fixed by #121 or canonical/prometheus-hardware-exporter#54
Closed

Fix duplication in metric names for failed collectors #125

dashmage opened this issue Dec 5, 2023 · 0 comments · Fixed by #121 or canonical/prometheus-hardware-exporter#54
Assignees
@dashmage
Labels
bug Something isn't working

Comments

@dashmage
Copy link
Contributor

dashmage commented Dec 5, 2023

The failed collector metric has "collector" twice in its name.
Eg: "ipmidcmicollector_collector_failed"

This change aims to remove the duplication. Previous example becomes "ipmidcmi_collector_failed"
@dashmage dashmage added the bug Something isn't working label Dec 5, 2023
@dashmage dashmage self-assigned this Dec 5, 2023
This was linked to pull requests Dec 5, 2023
refactor: Fix alert rules for failed collector. #121
Merged
refactor: Fix failed metric names. canonical/prometheus-hardware-exporter#54
Merged
@jneo8 jneo8 closed this as completed in #121 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashmage dashmage

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@dashmage