Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fix alert rules for failed collector. #121

Merged
merged 3 commits into from
Dec 5, 2023
Merged

refactor: Fix alert rules for failed collector. #121

merged 3 commits into from
Dec 5, 2023

Conversation

dashmage
Copy link
Contributor

@dashmage dashmage commented Dec 1, 2023

@dashmage dashmage requested review from a team, Pjack, aieri, agileshaw, jneo8 and rgildein December 1, 2023 14:19
@dashmage dashmage mentioned this pull request Dec 1, 2023
Merged
@dashmage dashmage force-pushed the refactor/collector-fail-alert-rules branch from 48f5943 to 0f66ae1 Compare December 4, 2023 07:00
@dashmage
Set asyncio mark in test module.
36be586 
func tests for juju 2.9/focal were failing. This was because the asyncio
marker was not added to the tests.

This change adds the markers automatically to all the tests by setting
`pytestmark`.
@dashmage dashmage force-pushed the refactor/collector-fail-alert-rules branch from 0f66ae1 to 36be586 Compare December 4, 2023 07:02
rgildein
rgildein reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need informations

tests/functional/test_charm.py Outdated Show resolved Hide resolved
Pjack
Pjack approved these changes Dec 5, 2023
View reviewed changes
Copy link

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's good to me. Please add the comment suggested from Robert.

tests/functional/test_charm.py Outdated Show resolved Hide resolved
jneo8
jneo8 requested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to remove the line which provide pytest-asyncio fix.

tests/functional/test_charm.py Outdated Show resolved Hide resolved
@chanchiwai-ray
Copy link
Contributor

chanchiwai-ray commented Dec 5, 2023 •
edited
Loading

Not related to this PR, are we actually performing the lint test of the alert rules?

@dashmage
Copy link
Contributor Author

dashmage commented Dec 5, 2023

Not related to this PR, are we actually performing the static test of the alert rules?

If you mean running promtool, this is done manually before committing the code currently. There's no automated process in place yet :(

@dashmage
Copy link
Contributor Author

dashmage commented Dec 5, 2023

Update: Functional tests are green, looks good to merge!
Latest job run

@dashmage dashmage mentioned this pull request Dec 5, 2023
Closed
@dashmage dashmage requested a review from jneo8 December 5, 2023 07:45
@dashmage dashmage linked an issue Dec 5, 2023 that may be closed by this pull request
Fix duplication in metric names for failed collectors #125
Closed
rgildein
rgildein approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jneo8 jneo8 merged commit 08c5079 into canonical:master Dec 5, 2023
4 checks passed
@dashmage dashmage deleted the refactor/collector-fail-alert-rules branch December 5, 2023 11:48
@dashmage dashmage mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgildein rgildein rgildein approved these changes

@jneo8 jneo8 jneo8 approved these changes

@Pjack Pjack Pjack approved these changes

@aieri aieri Awaiting requested review from aieri

@agileshaw agileshaw Awaiting requested review from agileshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix duplication in metric names for failed collectors
5 participants
@dashmage @chanchiwai-ray @Pjack @jneo8 @rgildein