Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage endpoint should be storages instead of storage #91

Closed
nishant-dash opened this issue Nov 8, 2023 · 1 comment · Fixed by canonical/prometheus-hardware-exporter#49
Closed

storage endpoint should be storages instead of storage #91

nishant-dash opened this issue Nov 8, 2023 · 1 comment · Fixed by canonical/prometheus-hardware-exporter#49
Assignees
@dashmage
Labels
bug Something isn't working
Milestone
23.10.1

Comments

@nishant-dash
Copy link

In redfish.py I see

  storage_root_uri_pattern = "/redfish/v1/Systems/{}/Storage"

however on a node such as huawei, I see

$ curl -s -k -X GET "https://$IP/redfish/v1/Systems/1" -u $USER:$PASSWORD | jq . | grep -i stor
  "Storage": {
    "@odata.id": "/redfish/v1/Systems/1/Storages"
...

Storages vs Storage
@Pjack
Copy link

Pjack commented Nov 9, 2023

Huawei doesn't follow standard spec. But we will try to support it.

@Pjack Pjack added the bug Something isn't working label Nov 9, 2023
@dashmage dashmage self-assigned this Nov 16, 2023
@przemeklal przemeklal mentioned this issue Nov 16, 2023
Closed
@jneo8 jneo8 mentioned this issue Nov 16, 2023
Closed
@dashmage dashmage mentioned this issue Nov 17, 2023
Merged
dashmage added a commit to canonical/prometheus-hardware-exporter that referenced this issue Nov 23, 2023
@dashmage
fix(redfish): Make redfish storage name in URI dynamic. (#49)
03a17a7 
* fix(redfish): Make redfish storage name in URI dynamic.

The redfish storage name in the URI was initially hardcoded to "Storage".
On some servers which did not conform to the schema specification, this
name was provided differently, eg: Storages.

This change aims to find the storage uri name dynamically while fetching
the storage controller and storage drive data.

Also:
* Add new unit test + fix old ones.
* Remove unit test number prefixes.
* Remove unnecessary assertions from unit tests.

Fixes canonical/hardware-observer-operator#91, canonical/hardware-observer-operator#108
@Pjack Pjack added this to the 23.10.1 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashmage dashmage

Labels
bug Something isn't working
Projects
None yet
Milestone
23.10.1
Development

Successfully merging a pull request may close this issue.

fix(redfish): Make redfish storage name in URI dynamic. dashmage/prometheus-hardware-exporter
3 participants
@Pjack @nishant-dash @dashmage