fix(redfish): Make redfish storage name in URI dynamic. #49
+164
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redfish storage name in the URI was initially hardcoded to "Storage". On some servers which did not conform to the schema specification, this name was provided differently, eg: Storages. This change aims to find the storage uri name dynamically while fetching the storage controller and storage drive data. Fixes #91, #108
|
There's duplicate code between the Update: This refactoring work seems to be much more complicated than on first glance and there needs to be some thought behind the design. One server may have many different system ids each with multiple storage ids and each of those could have many storage controllers/ storage drives. Will tackle this in another PR if necessary in order to avoid increasing this PRs scope too much. New issue raised here: #51 |
Pjack
requested changes
Nov 17, 2023
rgildein
reviewed
Nov 20, 2023
Also add unit test for new method.
Pjack
requested changes
Nov 20, 2023
Pjack
reviewed
Nov 21, 2023
- Remove API call assertions. - Remove systems id related assertions
jneo8
requested changes
Nov 22, 2023
- Update system_dict name. - make `systems_root_uri` a class var. - make `_storage_root_uri` a classmethod.
jneo8
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redfish storage name in the URI was initially hardcoded to "Storage". On some servers which did not conform to the schema specification, this name was provided differently, eg: Storages.
This change aims to find the storage uri name dynamically while fetching the storage controller and storage drive data.
Fixes canonical/hardware-observer-operator#91, canonical/hardware-observer-operator#108